Implement SpecifiedTradeAllowanceCharges on TradeLineItems for UBL #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced handling for specified trade allowance charges in trade line items, including new XML elements for allowance details.
Updated handling of optional fields for trade allowance charges to ensure proper checks and formatting. Added conditional logic for ChargePercentage and BasisAmount fields to avoid unnecessary serialization of null values. Improved readability and consistency by using helper methods for enum descriptions.
|
Thanks for the pull request. |
Replaced `GetSpecifiedTradeAllowanceCharges` with `GetSpecifiedTradeCharges` to align with naming conventions. Updated reason code serialization method from `GetDescriptionAttribute` to `EnumToString` for improved clarity and consistency.
Just saw it after i merged my branch, was about 30 commits behind. |
Extracted redundant logic into a new private method `_WriteItemLevelSpecifiedTradeAllowanceCharge` to improve code readability and maintainability. Simplified loop structure by reusing this method for both trade allowances and trade charges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.